jayzhan211 commented on code in PR #9108:
URL: https://github.com/apache/arrow-datafusion/pull/9108#discussion_r1499273870
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -433,6 +435,7 @@ pub fn array_element(args: &[ArrayRef]) -> Result<ArrayRef>
{
let indexes = as_int64_array(&args[1])?;
general_array_element::<i64>(array, indexes)
}
+ DataType::Null => Ok(args[0].clone()),
Review Comment:
I think handling null here makes it confusing where it is nulls handled, is
it handled in`coercion` step `coerce signature` or here (array_expressions).
The test in array.slt only process once. We can only know it is handled
correctly, but unsure which one does the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
