alamb opened a new issue, #9286: URL: https://github.com/apache/arrow-datafusion/issues/9286
### Is your feature request related to a problem or challenge? Part of https://github.com/apache/arrow-datafusion/issues/9285 and https://github.com/apache/arrow-datafusion/issues/8045 The goal is to extract function definitions out of the datafusion core. ### Describe the solution you'd like Move the `abs` function to `datafusion-functions` Target location: https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions/src/math Here is an example function: `isnan`: https://github.com/apache/arrow-datafusion/blob/e1f7b245168c5762135abc4e594bd81c508d7186/datafusion/functions/src/math/nans.rs#L31-L48 There is already coverage in https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/scalar.slt Here are the steps I followed when porting `isnan`: 1. Create a ScalarUDFImpl in the functions crate following an existing example, and stub out the `invoke()` function with `todo!()`. 2. Make sure `cargo check -p datafusion-functions --all-features` compiles successfully 2. Remove the enum in `BuiltInScalarFunctions` ([source link](https://github.com/apache/arrow-datafusion/blob/e1f7b245168c5762135abc4e594bd81c508d7186/datafusion/expr/src/built_in_function.rs#L43)) 3. Try and build with `cargo check -p datafusion` and the compiler will point out all the places in the code that has logic for this function 4. While removing old code, copy the relevant parts back into the UDFs (like `signature`, and `return_type` and implementation for `invoke()` 5. Verify that the sqllogictests pass: ` ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
