jayzhan211 commented on code in PR #5408:
URL: https://github.com/apache/arrow-rs/pull/5408#discussion_r1495866914
##########
arrow-ord/src/cmp.rs:
##########
@@ -198,12 +316,16 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum)
-> Result<BooleanArray,
let r = r_v.map(|x| x.values().as_ref()).unwrap_or(r);
let r_t = r.data_type();
- if l_t != r_t || l_t.is_nested() {
+ if l_t != r_t {
Review Comment:
I return an error in `process_nested`, so the nested type that is NYI will
not go down there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
