jayzhan211 commented on code in PR #5408:
URL: https://github.com/apache/arrow-rs/pull/5408#discussion_r1495998589
##########
arrow-ord/src/cmp.rs:
##########
@@ -166,6 +168,122 @@ pub fn not_distinct(lhs: &dyn Datum, rhs: &dyn Datum) ->
Result<BooleanArray, Ar
compare_op(Op::NotDistinct, lhs, rhs)
}
+fn process_nested(
+ l: &dyn Array,
+ r: &dyn Array,
+ op: Op,
+ l_t: &DataType,
+ r_t: &DataType,
+ len: usize,
+) -> Result<Option<BooleanArray>, ArrowError> {
+ use arrow_schema::DataType::*;
+ if let (List(_), List(_)) = (l_t, r_t) {
+ // Process nested data types
+ match op {
Review Comment:
Not sure how to use l.values and offsets to do the comparison. I still try
out looping the index with `.value(I)`, which is much more straightforward to
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
