SteveLauC commented on PR #9297: URL: https://github.com/apache/arrow-datafusion/pull/9297#issuecomment-1956306126
> Hi @alamb, I think I might need some help on the sqllogictest CI error, with the `acos()` function implemented in this PR: > > 1. `select(acos(NULL)` would return a column of type `?` rather than `R` > 2. `select(acos(0), acos(1))` would return columns of type `II` rather than `RR` > > Honestly, I have no idea about the above behavios... Update: I just realized that it is a mistake that I made in `<AsocFunc as ScalarUDFImpl>::return_type()` ----- It feels that when we do `select(acos(NULL))`, `AsocFunc::return_type()` can see the passed `DataType::Null`, but `AsocFunc::invoke()` cannot because I didn't see a following panic message: ``` Unsupported data type DataType::Null for function asoc ``` It seems that DataFusion will handle those special values for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
