SteveLauC commented on code in PR #9297:
URL: https://github.com/apache/arrow-datafusion/pull/9297#discussion_r1498546692
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -545,7 +545,7 @@ message InListNode {
enum ScalarFunction {
Abs = 0;
- Acos = 1;
+ // 1 was Acos
Review Comment:
> hould we consider keeping it, perhaps by renaming it to Deprecated_Acos,
and then decode it into the new ScalarUDF to maintain better backward
compatibility?
I followed the way that how #9216 handed it, gentle ping on @alamb, maybe
you have some thoughts on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
