yyy1000 commented on code in PR #9313:
URL: https://github.com/apache/arrow-datafusion/pull/9313#discussion_r1500954906
##########
datafusion/functions/src/macros.rs:
##########
@@ -160,3 +160,43 @@ macro_rules! downcast_arg {
})?
}};
}
+
+macro_rules! make_abs_function {
Review Comment:
Yeah, these are not new macros, but from datafusion-physical_expr like
https://github.com/apache/arrow-datafusion/pull/9216/files#r1487960276 said.
I think it's also OK to import and reuse the existing macros, but I think in
the future if all functions are moved, macros should also move.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
