jayzhan211 commented on code in PR #9313:
URL: https://github.com/apache/arrow-datafusion/pull/9313#discussion_r1502302796
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -545,8 +545,9 @@ message InListNode {
}
enum ScalarFunction {
- Abs = 0;
- Acos = 1;
+ // 0 was Abs
+ // The first enum value must be zero for open enums
+ Acos = 0;
Review Comment:
This breaks the code that use 1 for Acos. I think you can keep it as it is
for this PR
After moving them all to UDF, this enum can be deprecated.
I think we need to add `unknown = 0` in the future for enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
