andrebsguedes commented on code in PR #5425:
URL: https://github.com/apache/arrow-rs/pull/5425#discussion_r1501474855


##########
object_store/src/azure/credential.rs:
##########
@@ -127,6 +127,10 @@ pub enum AzureCredential {
     ///
     /// 
<https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-azure-active-directory>
     BearerToken(String),
+    /// No authorization (anonymous read access)
+    ///
+    /// 
<https://learn.microsoft.com/en-us/azure/storage/blobs/anonymous-read-access-configure>
+    None,

Review Comment:
   As we expose `MicrosoftAzure::credentials` to users there is no way to have 
a "no credentials" state without a breaking change.
   
   I have changed the implementation to not require a breaking change by just 
skipping the authorization internally (as we do for S3).
   
   Also, with this change the `disable_emulator_key` option does not make sense 
anymore and was removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to