tustvold commented on code in PR #5425:
URL: https://github.com/apache/arrow-rs/pull/5425#discussion_r1501842190
##########
object_store/src/azure/builder.rs:
##########
@@ -809,15 +830,20 @@ impl MicrosoftAzureBuilder {
// Allow overriding defaults. Values taken from
// from
https://docs.rs/azure_storage/0.2.0/src/azure_storage/core/clients/storage_account_client.rs.html#129-141
let url = url_from_env("AZURITE_BLOB_STORAGE_URL",
"http://127.0.0.1:10000";)?;
- let key = match self.access_key {
- Some(k) => AzureAccessKey::try_new(&k)?,
- None => AzureAccessKey::try_new(EMULATOR_ACCOUNT_KEY)?,
+ let credential = if let Some(k) = self.access_key {
Review Comment:
IIRC the emulator doesn't support other forms of credential though? I think
I would prefer to roll this back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
