alamb commented on code in PR #9239:
URL: https://github.com/apache/arrow-datafusion/pull/9239#discussion_r1504198174
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -2247,6 +2292,196 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn register_deregister_udf() -> Result<()> {
Review Comment:
Would it be possible to move these tests to
https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/user_defined/mod.rs
Doing so would make them more discoverable as well as likely shorter as you
could probably avoid having to define ScalarUDFs
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -848,6 +848,21 @@ impl SessionContext {
self.state.write().register_udwf(Arc::new(f)).ok();
}
+ /// Deregisters a UDF within this context.
+ pub fn deregister_udf(&self, name: &str) {
+ self.state.write().deregister_udf(name).ok();
+ }
+
+ /// Deregisters a UDAF within this context.
+ pub fn deregister_udaf(&self, name: &str) {
+ self.state.write().deregister_udaf(name).ok();
+ }
+
+ /// Deregisters a UDTF within this context.
Review Comment:
```suggestion
/// Deregisters a UDWF within this context.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
