viirya commented on code in PR #128:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/128#discussion_r1505285612
##########
README.md:
##########
@@ -97,10 +97,13 @@ Query the data from the test source and check:
- INFO message shows the native Comet library has been initialized.
- The query plan reflects Comet operators being used for this query instead of
Spark ones
```scala
-scala> spark.read.parquet("/tmp/test").createOrReplaceTempView("t1");
spark.sql("select * from t1 where a > 5").explain
+scala> spark.read.parquet("/tmp/test").createOrReplaceTempView("t1")
+scala> spark.sql("select * from t1 where a > 5").explain
INFO src/lib.rs: Comet native library initialized
== Physical Plan ==
*(1) ColumnarToRow
+- CometFilter [a#14], (isnotnull(a#14) AND (a#14 > 5))
-+- CometScan parquet [a#14] Batched: true, DataFilters: [isnotnull(a#14),
(a#14 > 5)], Format: CometParquet, Location: InMemoryFileIndex(1
paths)[file:/tmp/test], PartitionFilters: [], PushedFilters: [IsNotNull(a),
GreaterThan(a,5)], ReadSchema: struct<a:int>
++- CometScan parquet [a#14] Batched: true, DataFilters: [isnotnull(a#14),
(a#14 > 5)],
Review Comment:
The indent of `CometScan` is wrong.
<img width="1312" alt="Screenshot 2024-02-27 at 7 09 33 PM"
src="https://github.com/apache/arrow-datafusion-comet/assets/68855/cf2e2ccc-ae2b-4d27-bb46-55f5ae61de2e";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
