kou commented on PR #39824: URL: https://github.com/apache/arrow/pull/39824#issuecomment-1968972787
> I'm afraid the AppVeyor failures are related. They are probably due to `_CRT_SECURE_NO_WARNINGS` not being propagated to the object libraries. Shouldn't we propagate all preprocessor definitions to the object libraries? Oh, sorry. I forgot to check the AppVeyor failure. (I thought that it's a known failure.) https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/49271941?fullLog=true#L2735 ```text [ RUN ] StringConversion.ToBoolean unknown file: error: SEH exception with code 0xc0000005 thrown in the test body. Stack trace: [ FAILED ] StringConversion.ToBoolean (1 ms) ``` Hmm, it seems that it's a memory related problem. `_CRT_SECURE_NO_WARNINGS` may not be related because preprocessor definitions added by `add_definitions()` are used by all objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
