bkietz commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1506305911
##########
cpp/src/arrow/filesystem/filesystem.h:
##########
@@ -519,6 +574,82 @@ Result<std::shared_ptr<FileSystem>>
FileSystemFromUriOrPath(
/// @}
+/// \defgroup filesystem-factory-registration Helpers for FileSystem
registration
+///
+/// @{
+
+/// \brief Register a Filesystem factory
+///
+/// Support for custom Uri schemes can be added by registering a factory
+/// for the corresponding FileSystem.
+///
+/// \param[in] scheme a Uri scheme which the factory will handle.
+/// If a factory has already been registered for a scheme,
+/// the new factory will be ignored.
Review Comment:
Since this is mostly called from start up code where there isn't a
Status/Result stack to unwind, I thought it'd be acceptable to simply log or
ignore name conflicts. One alternative would be to store any errors and raise
them in future calls to FileSystemFromUri. Is that preferable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
