advancedxy commented on code in PR #83:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/83#discussion_r1506956772
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -65,28 +64,18 @@ abstract class CometTestBase
val conf = new SparkConf()
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
- conf.set("spark.shuffle.manager", shuffleManager)
+ conf.set(SQLConf.ANSI_ENABLED.key, "false")
+ conf.set(SHUFFLE_MANAGER, shuffleManager)
+ conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
Review Comment:
> Ideally we should be able to use DriverPlugin to override the memory
settings so Comet may just work out of box (need to change Spark in a few
places).
Oh. It seems that DriverPlugin is initialized before task scheduler. Which
places in Spark do we need for CometDriverPlugin to override memory settings?
The memory overhead is already override by comet.
>and can probably do the same here too.
Is this still in this PR's scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
