sunchao commented on code in PR #83:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/83#discussion_r1506959941
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -65,28 +64,18 @@ abstract class CometTestBase
val conf = new SparkConf()
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
- conf.set("spark.shuffle.manager", shuffleManager)
+ conf.set(SQLConf.ANSI_ENABLED.key, "false")
+ conf.set(SHUFFLE_MANAGER, shuffleManager)
+ conf.set(MEMORY_OFFHEAP_ENABLED.key, "true")
Review Comment:
> Oh. It seems that DriverPlugin is initialized before task scheduler. Which
places in Spark do we need for CometDriverPlugin to override memory settings?
The memory overhead is already override by comet.
I already made one change in Spark:
https://github.com/apache/spark/pull/45052 for this. We'll need a few more
changes so we can completely overwrite executor memory setting through
`DriverPlugin`.
> Is this still in this PR's scope?
Not really. Will do that in
https://github.com/apache/arrow-datafusion-comet/issues/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
