alamb commented on issue #9285: URL: https://github.com/apache/arrow-datafusion/issues/9285#issuecomment-1977562604
> ListRange likewise, which is kernel function in `function-arrays` crate, instead of converting ArrayRef to Expr, I'm thinking of making array function kernel public. @alamb Do you think we can make those array functions public? And, is importing `function-arrays` to crate `physical-expr` a concern like crate `optimize` is? I think making physical-exprs depend on datafusion-functions would be unfortunate (as it would still mean there could be dependencies / special cases from built in functions to "built in" user defined functions) > If neither is a good idea, we may need to rewrite ListIndex and ListRange to array function early. I agree if this is possible it would be the best approach from my perspective I also though about about potentially adding the common code to the new `datafusion_common_runtime` crate (that @mustafasrepo added recently) https://github.com/apache/arrow-datafusion/tree/main/datafusion/common_runtime But I think that would result in a tokio dependency on datafusion-functions which would be unwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
