Omega359 commented on issue #9285: URL: https://github.com/apache/arrow-datafusion/issues/9285#issuecomment-1977608388
> I think making physical-exprs depend on datafusion-functions would be unfortunate (as it would still mean there could be dependencies / special cases from built in functions to "built in" user defined functions) > > > If neither is a good idea, we may need to rewrite ListIndex and ListRange to array function early. > > I agree if this is possible it would be the best approach from my perspective Hmm. I had the same issue with datebin being referenced in physical-expr - though only for a test which likely could be moved elsewhere or somehow adjusted in some other way. The [draft pr](https://github.com/apache/arrow-datafusion/pull/9435) in fact does just replace it with the moved datebin and thus does import the functions crate. I'll look at updating those tests in some way to remove that dependency. I also encountered function [references ](https://github.com/apache/arrow-datafusion/blob/a84e5f89bd52d59c78f11fffbab89ed1d418538f/datafusion/sql/src/expr/mod.rs#L173) in the sql crate that I really can't see a way to work around unless we somehow allow SQLExpr to be a part of a ScalarUdf or similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
