houqp commented on a change in pull request #9412:
URL: https://github.com/apache/arrow/pull/9412#discussion_r569953550
##########
File path: rust/arrow/test/data/mixed_arrays.json
##########
@@ -1,4 +1,4 @@
-{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":4.1}
+{"a":1, "b":[2.0, 1.3, -6.1], "c":[false, true], "d":["4.1"]}
{"a":-10, "b":[2.0, 1.3, -6.1], "c":null, "d":null}
-{"a":2, "b":[2.0, null, -6.1], "c":[false, null], "d":"text"}
-{"a":3, "b":4, "c": true, "d":[1, false, "array", 2.4]}
+{"a":2, "b":[2.0, null, -6.1], "c":[false, null], "d":["text"]}
+{"a":3, "b":[], "c": [], "d":["array"]}
Review comment:
@nevi-me the I don't have the full context here, so my change of logic
here might not be correct. Basically the current implementation throws out an
type incompatible error when a column is detected to have both list and
non-list value, for example: `"c": true"` v.s. `"c": [true, false]`.
Do you remember what's the reason for doing automatic conversion between
scalar column to scalar list column? This behavior seems a bit too magical to
me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
