alamb commented on a change in pull request #9412:
URL: https://github.com/apache/arrow/pull/9412#discussion_r571606006
##########
File path: rust/arrow/src/json/reader.rs
##########
@@ -1874,9 +1997,7 @@ mod tests {
.downcast_ref::<ListArray>()
.unwrap();
let bb = bb.values();
- let bb = bb.as_any().downcast_ref::<Float64Array>().unwrap();
- assert_eq!(10, bb.len());
- assert!(4.0 - bb.value(9) < f64::EPSILON);
Review comment:
What happened to `bb.value(9)`?
##########
File path: rust/arrow/src/json/reader.rs
##########
@@ -57,6 +57,46 @@ use crate::record_batch::RecordBatch;
use crate::util::bit_util;
use crate::{array::*, buffer::Buffer};
+#[derive(Debug, Clone)]
+enum InferredType {
Review comment:
This is a nice and easy to follow implementation. Nice work @houqp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
