viirya commented on code in PR #9236:
URL: https://github.com/apache/arrow-datafusion/pull/9236#discussion_r1515257009
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -280,7 +283,8 @@ pub struct HashJoinExec {
pub filter: Option<JoinFilter>,
/// How the join is performed (`OUTER`, `INNER`, etc)
pub join_type: JoinType,
- /// The output schema for the join
+ /// The schema after join. Please be careful when using this schema,
+ /// if there is a projection, the schema isn't the same as the output
schema.
schema: SchemaRef,
Review Comment:
If it is easy to confuse, maybe change to `join_schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
