viirya commented on code in PR #9236:
URL: https://github.com/apache/arrow-datafusion/pull/9236#discussion_r1515377159
##########
datafusion/core/src/physical_optimizer/optimizer.rs:
##########
@@ -97,6 +97,8 @@ impl PhysicalOptimizer {
// Note that one should always run this rule after running the
EnforceDistribution rule
// as the latter may break local sorting requirements.
Arc::new(EnforceSorting::new()),
+ // TODO: `try_embed_to_hash_join` in the ProjectionPushdown rule
would be block by the CoalesceBatches, so add it before CoalesceBatches. Maybe
optimize it in the future.
+ Arc::new(ProjectionPushdown::new()),
Review Comment:
I guess so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
