ryan-syed commented on code in PR #1593:
URL: https://github.com/apache/arrow-adbc/pull/1593#discussion_r1529289794
##########
csharp/test/Drivers/Interop/Snowflake/SnowflakeTestingUtils.cs:
##########
@@ -133,11 +133,11 @@ SnowflakeTestConfiguration testConfiguration
/// Parses the queries from resources/SnowflakeData.sql
/// </summary>
/// <param name="testConfiguration"><see
cref="SnowflakeTestConfiguration"/></param>
- internal static string[] GetQueries(SnowflakeTestConfiguration
testConfiguration)
+ internal static string[] GetQueries(SnowflakeTestConfiguration
testConfiguration, string sqlFilePath = "resources/SnowflakeData.sql")
{
StringBuilder content = new StringBuilder();
- string[] sql = File.ReadAllLines("resources/SnowflakeData.sql");
+ string[] sql = File.ReadAllLines(sqlFilePath);
Review Comment:
converted to an embedded resource file and added error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
