dianaclarke commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r573274261
##########
File path: dev/archery/archery/utils/codec.py
##########
@@ -48,6 +48,8 @@ def encode(b):
"unit": b.unit,
"less_is_better": b.less_is_better,
"values": b.values,
+ "time_unit": b.time_unit,
Review comment:
Odd. Why is this file in `dev/archery/archery/utils/` when all other
archery benchmark code is in `dev/archery/archery/benchmark/`.
##########
File path: dev/archery/archery/utils/codec.py
##########
@@ -48,6 +48,8 @@ def encode(b):
"unit": b.unit,
"less_is_better": b.less_is_better,
"values": b.values,
+ "time_unit": b.time_unit,
Review comment:
Odd. Why is this file in `dev/archery/archery/utils/` when all other
archery benchmark code is in `dev/archery/archery/benchmark/`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
