dianaclarke commented on a change in pull request #9458:
URL: https://github.com/apache/arrow/pull/9458#discussion_r573328405
##########
File path: dev/archery/archery/benchmark/core.py
##########
@@ -27,11 +27,14 @@ def median(values):
class Benchmark:
- def __init__(self, name, unit, less_is_better, values, counters=None):
Review comment:
Because this shape change is additive, `archery benchmark diff` will
still work.
The downside, is that I would also like to eventually expose both
`items_per_second ` and `bytes_per_second` at some point, and the current shape
doesn't lend itself well to multiple benchmark units.
I suppose an alternative would be to not merge this commit at all, and
instead add a command line option to just exposes the unadulterated google
benchmark output which has all I need. For example:
```
{'cpu_time': 12718379.310344812,
'items_per_second': 20611431.18972546,
'iterations': 58,
'name': 'TakeStringRandomIndicesWithNulls/262144/0',
'null_percent': 0.0,
'real_time': 13292835.792526603,
'repetition_index': 0,
'repetitions': 0,
'run_name': 'TakeStringRandomIndicesWithNulls/262144/0',
'run_type': 'iteration',
'size': 262144.0,
'threads': 1,
'time_unit': 'ns'},
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
