jayzhan211 commented on code in PR #9801:
URL: https://github.com/apache/arrow-datafusion/pull/9801#discussion_r1538898075
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -401,3 +401,83 @@ async fn test_first_value_with_sort() -> Result<()> {
Ok(())
}
+
+#[tokio::test]
+async fn last_value() -> Result<()> {
+ let session_ctx = SessionContext::new();
+ session_ctx
+ .sql("CREATE TABLE abc AS VALUES (1, 2, 3), (null, 5, 6)")
Review Comment:
I think this kind of test are easier to maintain in
`datafusion/sqllogictest/test_files/aggregate.slt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
