yyy1000 commented on issue #9714: URL: https://github.com/apache/arrow-datafusion/issues/9714#issuecomment-2020606452
I'd like to try this, from the description, > Until the partition by parsing uses ColumnDef So maybe trying to make `partition by` use `ColumnDef`, currently, my plan is: 1. Make `table_partition_cols` field in https://github.com/apache/arrow-datafusion/blob/39f4aaf5cd1abfc9204c3eb96effdb4ebcf5b882/datafusion/sql/src/parser.rs#L206 `CreateExternalTable` statement to `Vec<ColumnRef>` 2. make `parse_partitions` return `ColumnRef` like `parse_columns`. https://github.com/apache/arrow-datafusion/blob/39f4aaf5cd1abfc9204c3eb96effdb4ebcf5b882/datafusion/sql/src/parser.rs#L542 3. In `external_table_to_plan`, do the same thing to `table_partition_cols` like `column_defaults` https://github.com/apache/arrow-datafusion/blob/39f4aaf5cd1abfc9204c3eb96effdb4ebcf5b882/datafusion/sql/src/statement.rs#L984-L987 So this will not convert the Ident value to string too early, but I also doubt whether it would fix this. I encountered similar issue related to `' ` characters in my past experience and it's a bit tricky. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
