pitrou commented on a change in pull request #9474:
URL: https://github.com/apache/arrow/pull/9474#discussion_r574719928
##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -160,6 +160,13 @@ Status FileWriter::Write(RecordBatchReader* batches) {
return Status::OK();
}
+Status FileWriter::Finish() {
+ RETURN_NOT_OK(FinishInternal());
+ return destination_->Close();
Review comment:
(and MockFileSystem will deliberately not write anything out if you
don't close it explicitly)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
