pitrou commented on a change in pull request #9474:
URL: https://github.com/apache/arrow/pull/9474#discussion_r582862583
##########
File path: cpp/src/arrow/csv/reader.cc
##########
@@ -935,18 +931,22 @@ class AsyncThreadedTableReader
AsyncGenerator<std::shared_ptr<Buffer>> buffer_generator_;
};
+} // namespace
+
/////////////////////////////////////////////////////////////////////////
// Factory functions
Result<std::shared_ptr<TableReader>> TableReader::Make(
- MemoryPool* pool, io::AsyncContext async_context,
- std::shared_ptr<io::InputStream> input, const ReadOptions& read_options,
- const ParseOptions& parse_options, const ConvertOptions& convert_options) {
+ MemoryPool* pool, io::IOContext io_context,
std::shared_ptr<io::InputStream> input,
+ const ReadOptions& read_options, const ParseOptions& parse_options,
+ const ConvertOptions& convert_options) {
std::shared_ptr<BaseTableReader> reader;
if (read_options.use_threads) {
- reader = std::make_shared<AsyncThreadedTableReader>(
- pool, input, read_options, parse_options, convert_options,
async_context.executor,
- internal::GetCpuThreadPool());
Review comment:
Note that the CPU and IO executors were passed in the wrong order here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
