liurenjie1024 commented on code in PR #9789:
URL: https://github.com/apache/arrow-datafusion/pull/9789#discussion_r1543939710
##########
datafusion/expr/Cargo.toml:
##########
@@ -43,6 +43,7 @@ arrow-array = { workspace = true }
chrono = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
paste = "^1.0"
+serde_json = { workspace = true }
Review Comment:
To be honest I'm not a big fan of manipulating string directly since it's
not easy to maintain. As you said, `serde_json` is already used by many places,
so I think it fine to use it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
