liurenjie1024 commented on code in PR #9789:
URL: https://github.com/apache/arrow-datafusion/pull/9789#discussion_r1543943635
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2781,6 +2802,70 @@ digraph {
Ok(())
}
+ #[test]
+ fn test_display_pg_json() -> Result<()> {
+ let plan = display_plan()?;
+
+ let expected_graphviz = r#"[
+ {
+ "Plan": {
+ "Expressions": [
+ "employee_csv.id"
+ ],
+ "Node Type": "Projection",
+ "Output": [
+ "id"
+ ],
+ "Plans": [
+ {
+ "Condition": "employee_csv.state IN (<subquery>)",
+ "Node Type": "Filter",
+ "Output": [
+ "id",
+ "state"
+ ],
+ "Plans": [
+ {
+ "Node Type": "Subquery",
+ "Output": [
+ "state"
+ ],
+ "Plans": [
+ {
+ "Node Type": "TableScan",
+ "Output": [
+ "state"
+ ],
+ "Plans": [],
+ "Relation Name": "employee_csv"
+ }
+ ]
+ },
+ {
+ "Node Type": "TableScan",
+ "Output": [
+ "id",
+ "state"
+ ],
+ "Plans": [],
+ "Relation Name": "employee_csv"
+ }
+ ]
+ }
+ ]
+ }
+ }
+]"#;
+ println!("{}", plan.display_pg_json());
+
+ // just test for a few key lines in the output rather than the
+ // whole thing to make test mainteance easier.
+ let graphviz = format!("{}", plan.display_pg_json());
Review Comment:
Fixed.
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2781,6 +2802,70 @@ digraph {
Ok(())
}
+ #[test]
+ fn test_display_pg_json() -> Result<()> {
+ let plan = display_plan()?;
+
+ let expected_graphviz = r#"[
+ {
+ "Plan": {
+ "Expressions": [
+ "employee_csv.id"
+ ],
+ "Node Type": "Projection",
+ "Output": [
+ "id"
+ ],
+ "Plans": [
+ {
+ "Condition": "employee_csv.state IN (<subquery>)",
+ "Node Type": "Filter",
+ "Output": [
+ "id",
+ "state"
+ ],
+ "Plans": [
+ {
+ "Node Type": "Subquery",
+ "Output": [
+ "state"
+ ],
+ "Plans": [
+ {
+ "Node Type": "TableScan",
+ "Output": [
+ "state"
+ ],
+ "Plans": [],
+ "Relation Name": "employee_csv"
+ }
+ ]
+ },
+ {
+ "Node Type": "TableScan",
+ "Output": [
+ "id",
+ "state"
+ ],
+ "Plans": [],
+ "Relation Name": "employee_csv"
+ }
+ ]
+ }
+ ]
+ }
+ }
+]"#;
+ println!("{}", plan.display_pg_json());
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
