alamb commented on a change in pull request #9473: URL: https://github.com/apache/arrow/pull/9473#discussion_r575794201
########## File path: rust/arrow/src/buffer/mod.rs ########## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains two main structs: [Buffer] and [MutableBuffer]. A buffer represents +//! a contiguous memory region that can be shared via `offsets`. + +mod immutable; +pub use immutable::*; +mod mutable; +pub use mutable::*; +mod ops; +pub(super) use ops::*; Review comment: FWIW it might not be possible bit I think in general making `Buffer` and `MutableBuffer` etc less exposed is a good direction -- they become implementation details that can then be more freely changed without affecting users (e.g. it would make things like https://github.com/jorgecarleitao/arrow2/pull/1 easier) . In other words, making ops crate public might be a *good* thing (even if it is a potentially breaking one) I realize the cat may already be out of the bag there, but I think being more deliberate about what interfaces are public and what are private would help developers and users going forward ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
