nevi-me commented on a change in pull request #9473: URL: https://github.com/apache/arrow/pull/9473#discussion_r575795924
########## File path: rust/arrow/src/buffer/mod.rs ########## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! This module contains two main structs: [Buffer] and [MutableBuffer]. A buffer represents +//! a contiguous memory region that can be shared via `offsets`. + +mod immutable; +pub use immutable::*; +mod mutable; +pub use mutable::*; +mod ops; +pub(super) use ops::*; Review comment: > making ops crate public might be a _good_ thing My view's that if someone's manipulating bits in a general way that's not related to Arrow, they shouldn't be using these `ops`. So I agree with not making them public. After looking at https://doc.rust-lang.org/reference/visibility-and-privacy.html, I see that I used the wrong terminology. As now making `arrow::buffer::buffer_bin_or` inaccessible to arrow's consumers, this is a semantic change. @jorgecarleitao WDYT about returning it to `pub use ops::*`, and then we can address which of our laundry we hang to the public, in future? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
