paleolimbot commented on PR #1708:
URL: https://github.com/apache/arrow-adbc/pull/1708#issuecomment-2037420649
Thank you for finding the root cause!
I checked with:
```shell
# docker run --rm -it rhub/clang18
apt-get install -y git libpq-dev
R -e 'install.packages("adbcdrivermanager")'
# Reproduces failure
git clone https://github.com/apache/arrow-adbc.git
cd arrow-adbc/r/adbcpostgresql
PKG_CXXFLAGS=-Werror R CMD INSTALL . --preclean
# /usr/lib/llvm-18/bin/../include/c++/v1/__fwd/string_view.h:22:41: error:
'char_traits<fmt::detail::char8_type>' is deprecated: char_traits<T> for T not
equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is
provided for a temporary period. It will be removed in LLVM 19, so please
migrate off of it. [-Werror,-Wdeprecated-declarations]
# Checks that this PR fixes it (it does!)
cd /
git clone https://github.com/lidavidm/arrow-adbc.git
cd arrow-adbc/r/adbcpostgresql
git switch gh-1705
PKG_CXXFLAGS=-Werror R CMD INSTALL . --preclean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
