alamb commented on a change in pull request #9309:
URL: https://github.com/apache/arrow/pull/9309#discussion_r576393334
##########
File path: dev/archery/archery/benchmark/compare.py
##########
@@ -25,11 +25,11 @@ def items_per_seconds_fmt(value):
if value < 1000:
return "{} items/sec".format(value)
if value < 1000**2:
- return "{:.3f}k items/sec".format(value / 1000)
+ return "{:.3f}K items/sec".format(value / 1000)
Review comment:
was this an intended change in this PR? I don't know anything about the
archery benchmark driver, so I think someone who does should probably review
these changes if they are needed in this PR
##########
File path: rust/arrow/src/array/array.rs
##########
@@ -326,6 +327,170 @@ pub fn new_empty_array(data_type: &DataType) -> ArrayRef {
let data = ArrayData::new_empty(data_type);
make_array(Arc::new(data))
}
+/// Creates a new array of `data_type` of length `length` filled entirely of
`NULL` values
+pub fn new_null_array(data_type: &DataType, length: usize) -> ArrayRef {
Review comment:
I am not sure why this code is in this PR (maybe the PR needs a rebase)?
It was merged into master as part of https://github.com/apache/arrow/pull/9469
I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
