houqp commented on pull request #9309: URL: https://github.com/apache/arrow/pull/9309#issuecomment-778694710
@Dandandan @alamb ready for another round of review. Given this PR has grown into 900 lines, I think it would be better to work on a new `ExprRewriter` a refactor only PR to ease the review process. We will be able to get a better idea of how the new framework works by applying it to multiple optimization rules in the same patch set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org