alexandreyc commented on code in PR #1725: URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567840868
########## rust2/core/src/ffi/constants.rs: ########## @@ -0,0 +1,101 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::os::raw::c_int; + +use super::types::FFI_AdbcStatusCode; + +pub const ADBC_STATUS_OK: FFI_AdbcStatusCode = 0; +pub const ADBC_STATUS_UNKNOWN: FFI_AdbcStatusCode = 1; +pub const ADBC_STATUS_NOT_IMPLEMENTED: FFI_AdbcStatusCode = 2; +pub const ADBC_STATUS_NOT_FOUND: FFI_AdbcStatusCode = 3; +pub const ADBC_STATUS_ALREADY_EXISTS: FFI_AdbcStatusCode = 4; +pub const ADBC_STATUS_INVALID_ARGUMENT: FFI_AdbcStatusCode = 5; +pub const ADBC_STATUS_INVALID_STATE: FFI_AdbcStatusCode = 6; +pub const ADBC_STATUS_INVALID_DATA: FFI_AdbcStatusCode = 7; +pub const ADBC_STATUS_INTEGRITY: FFI_AdbcStatusCode = 8; +pub const ADBC_STATUS_INTERNAL: FFI_AdbcStatusCode = 9; +pub const ADBC_STATUS_IO: FFI_AdbcStatusCode = 10; +pub const ADBC_STATUS_CANCELLED: FFI_AdbcStatusCode = 11; +pub const ADBC_STATUS_TIMEOUT: FFI_AdbcStatusCode = 12; +pub const ADBC_STATUS_UNAUTHENTICATED: FFI_AdbcStatusCode = 13; +pub const ADBC_STATUS_UNAUTHORIZED: FFI_AdbcStatusCode = 14; + +pub const ADBC_VERSION_1_0_0: i32 = 1000000; +pub const ADBC_VERSION_1_1_0: i32 = 1001000; Review Comment: In `adbc.h`, `AdbcDriverInitFunc` take `version` as `c_int`. Maybe we should use `c_int` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
