mapleFU commented on code in PR #41580:
URL: https://github.com/apache/arrow/pull/41580#discussion_r1597555937
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1584,6 +1619,13 @@ class
ColumnChunkMetaDataBuilder::ColumnChunkMetaDataBuilderImpl {
return column_chunk_->meta_data.total_compressed_size;
}
+ KeyValueMetadata& key_value_metadata() {
+ if (!key_value_metadata_) {
+ key_value_metadata_ = std::make_unique<KeyValueMetadata>();
+ }
+ return *key_value_metadata_;
Review Comment:
So once `key_value_metadata()` is called, the metadata is generated, and the
metadata would be put in `SetKeyValueMetadata`?
Should we just add a "Put" here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
