zanmato1984 commented on code in PR #41335:
URL: https://github.com/apache/arrow/pull/41335#discussion_r1598892694
##########
cpp/src/arrow/compute/key_hash_internal.h:
##########
@@ -48,6 +48,12 @@ class ARROW_EXPORT Hashing32 {
static void HashMultiColumn(const std::vector<KeyColumnArray>& cols,
LightContext* ctx,
uint32_t* out_hash);
+ // Clarify the max temp stack usage for HashBatch so the caller could
reserve enough
+ // size in advance.
Review Comment:
More comments added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
