nealrichardson commented on a change in pull request #9521: URL: https://github.com/apache/arrow/pull/9521#discussion_r581423955
########## File path: r/R/dplyr.R ########## @@ -73,6 +80,22 @@ print.arrow_dplyr_query <- function(x, ...) { invisible(x) } +get_field_names <- function(selected_cols) { + if (inherits(selected_cols, "arrow_dplyr_query")) { + selected_cols <- selected_cols$selected_columns + } + map_chr(selected_cols, ~.$field_name %||% .$args$field_name %||% "") Review comment: I can comment, though FWIW I'm pretty sure this will crash once dataset expressions might not be field_refs (in the next PR) so it's likely to be rewritten. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org