nealrichardson commented on a change in pull request #9521:
URL: https://github.com/apache/arrow/pull/9521#discussion_r581425493
##########
File path: r/R/dplyr.R
##########
@@ -423,26 +482,115 @@ ungroup.arrow_dplyr_query <- function(x, ...) {
}
ungroup.Dataset <- ungroup.ArrowTabular <- force
-mutate.arrow_dplyr_query <- function(.data, ...) {
+mutate.arrow_dplyr_query <- function(.data,
+ ...,
+ .keep = c("all", "used", "unused",
"none"),
+ .before = NULL,
+ .after = NULL) {
+ call <- match.call()
+ exprs <- quos(...)
+ if (length(exprs) == 0) {
+ # Nothing to do
+ return(.data)
+ }
+
.data <- arrow_dplyr_query(.data)
if (query_on_dataset(.data)) {
not_implemented_for_dataset("mutate()")
}
- # TODO: see if we can defer evaluating the expressions and not collect here.
- # It's different from filters (as currently implemented) because the basic
- # vector transformation functions aren't yet implemented in Arrow C++.
- dplyr::mutate(dplyr::collect(.data), ...)
+
+ .keep <- match.arg(.keep)
+ .before <- enquo(.before)
+ .after <- enquo(.after)
+ # Restrict the cases we support for now
+ if (!quo_is_null(.before) || !quo_is_null(.after)) {
+ # TODO(ARROW-11701)
+ return(abandon_ship(call, .data, '.before and .after arguments are not
supported in Arrow'))
+ } else if (length(group_vars(.data)) > 0) {
+ # mutate() on a grouped dataset does calculations within groups
+ # This doesn't matter on scalar ops (arithmetic etc.) but it does
+ # for things with aggregations (e.g. subtracting the mean)
+ return(abandon_ship(call, .data, 'mutate() on grouped data not supported
in Arrow'))
Review comment:
That won't always be a solution though. `dplyr::mutate()` behaves
differently on a grouped dataset: it will do grouped transformations and
aggregations.
FWIW for Table/RecordBatch, this won't error: it warns and then pulls data
into R and proceeds with the regular dplyr methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
