ryan-syed commented on code in PR #1884:
URL: https://github.com/apache/arrow-adbc/pull/1884#discussion_r1617980732


##########
csharp/test/Drivers/Apache/Spark/DriverTests.cs:
##########
@@ -37,6 +37,38 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Spark
     [TestCaseOrderer("Apache.Arrow.Adbc.Tests.Xunit.TestOrderer", 
"Apache.Arrow.Adbc.Tests")]
     public class DriverTests : SparkTestBase
     {
+        /// <summary>
+        /// Supported Spark data types as a subset of <see 
cref="SparkConnection.ColumnTypeId"/>
+        /// </summary>
+        private enum SupportedSparkDataType : short
+        {
+            ARRAY_TYPE = 2003,

Review Comment:
   Should we use ARRAY_TYPE = `ColumnTypeId.ARRAY_TYPE`? In case of value 
update, it would be required at only one location?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to