vibhatha commented on code in PR #41825:
URL: https://github.com/apache/arrow/pull/41825#discussion_r1620375118
##########
java/algorithm/pom.xml:
##########
@@ -48,5 +52,87 @@
</dependency>
</dependencies>
- <build></build>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>3.1.0</version>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <profiles>
+ <profile>
+ <id>spotless</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless.version}</version>
+ <configuration>
+ <formats>
+ <format>
Review Comment:
> The configuration for pom could be moved to the parent with path being
${maven.multiModuleProjectDirectory}/java/dev/license/asf-xml.license} (should
be safe to use because the project has a .mvn directory present). As it will
reformat several existing pom.xml who inherits the configuration (there's a
small indentation change), maybe we should address it as a standalone change
like we did for https://github.com/apache/arrow/issues/41173
Yes, this what I am also suggesting. We should do it in a single PR later
on. And when we do this change per module, the diff on the last PR would be
smaller or it could be just the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
