felipecrv commented on code in PR #41971:
URL: https://github.com/apache/arrow/pull/41971#discussion_r1626778707
##########
cpp/src/arrow/type.cc:
##########
@@ -3149,20 +3149,20 @@ std::shared_ptr<DataType> time64(TimeUnit::type unit) {
return std::make_shared<Time64Type>(unit);
}
-std::shared_ptr<DataType> list(const std::shared_ptr<DataType>& value_type) {
- return std::make_shared<ListType>(value_type);
+std::shared_ptr<DataType> list(std::shared_ptr<DataType> value_type) {
+ return std::make_shared<ListType>(std::move(value_type));
}
-std::shared_ptr<DataType> list(const std::shared_ptr<Field>& value_field) {
- return std::make_shared<ListType>(value_field);
+std::shared_ptr<DataType> list(std::shared_ptr<Field> value_field) {
+ return std::make_shared<ListType>(std::move(value_field));
}
-std::shared_ptr<DataType> large_list(const std::shared_ptr<DataType>&
value_type) {
- return std::make_shared<LargeListType>(value_type);
+std::shared_ptr<DataType> large_list(std::shared_ptr<DataType> value_type) {
+ return std::make_shared<LargeListType>(std::move(value_type));
}
-std::shared_ptr<DataType> large_list(const std::shared_ptr<Field>&
value_field) {
- return std::make_shared<LargeListType>(value_field);
+std::shared_ptr<DataType> large_list(std::shared_ptr<Field> value_field) {
+ return std::make_shared<LargeListType>(std::move(value_field));
Review Comment:
@amoeba this is related to what we've been discussing about conventions on
type signatures in C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
