felipecrv commented on code in PR #41971: URL: https://github.com/apache/arrow/pull/41971#discussion_r1626779898
########## cpp/src/arrow/type_fwd.h: ########## @@ -525,19 +525,19 @@ std::shared_ptr<DataType> decimal256(int32_t precision, int32_t scale); /// \brief Create a ListType instance from its child Field type ARROW_EXPORT -std::shared_ptr<DataType> list(const std::shared_ptr<Field>& value_type); +std::shared_ptr<DataType> list(std::shared_ptr<Field> value_type); Review Comment: @bkietz @pitrou should we treat this as a breaking change? If merging this causes no issue on the next release, I'm going to be more aggressive refactoring signatures moving forward (making sure I don't introduce bugs causes by `std::move`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
