WillAyd commented on code in PR #483:
URL: https://github.com/apache/arrow-nanoarrow/pull/483#discussion_r1633802767
##########
src/nanoarrow/nanoarrow_testing_test.cc:
##########
@@ -470,7 +470,7 @@ TEST(NanoarrowTestingTest,
NanoarrowTestingTestFieldMetadata) {
NANOARROW_RETURN_NOT_OK(ArrowSchemaSetMetadata(schema, "\0\0\0\0"));
return NANOARROW_OK;
},
- [](ArrowArray* array) { return NANOARROW_OK; }, &WriteFieldJSON,
+ [](ArrowArray*) { return NANOARROW_OK; }, &WriteFieldJSON,
Review Comment:
Not strictly related but it showed as a warning we could control with the
Meson warning configuration
##########
meson.build:
##########
@@ -34,3 +34,14 @@ subdir('src/nanoarrow')
if get_option('benchmarks')
subdir('dev/benchmarks')
endif
+
+
+if get_option('apps')
Review Comment:
I should really move the `meson.build` from the src/nanoarrow directory up
to here to mirror what is done for CMake, but am leaving that for a separate
PR. For now just put this apps piece up here since it does not live in
src/nanoarrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
