westonpace commented on a change in pull request #9561: URL: https://github.com/apache/arrow/pull/9561#discussion_r583113776
########## File path: r/R/dataset-partition.R ########## @@ -72,19 +77,22 @@ HivePartitioning$create <- dataset___HivePartitioning #' Because fields are named in the path segments, order of fields passed to #' `hive_partition()` does not matter. #' @param ... named list of [data types][data-type], passed to [schema()] +#' @param null_fallback character to be used in place of `NA` and `NULL` values +#' in columns that are being partitioned by. (default: +#' `"__HIVE_DEFAULT_PARTITION__"`) Review comment: Lots of tools follow this convention, Spark, Athena, Redshift, Impala. They all refer to this style of partitioning as "hive partitioning". I don't think Hive itself is always involved. I'm not sure if Hive came first or if this was a Spark convention that spun off into Hive or how things were ordered. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org