westonpace commented on a change in pull request #9561:
URL: https://github.com/apache/arrow/pull/9561#discussion_r582344610
##########
File path: r/R/dataset-write.R
##########
@@ -41,6 +41,9 @@
#' will yield `"part-0.feather", ...`.
#' @param hive_style logical: write partition segments as Hive-style
#' (`key1=value1/key2=value2/file.ext`) or as just bare values. Default is
`TRUE`.
+#' @param hive_null_fallback If writing partition segments as Hive-style
Review comment:
I think omitting is fine. The line `partitioning <-
HivePartitioning$create(partition_schema, hive_null_fallback)` would become
`partitioning <- hive_partition(partition_schema)` as `HivePartitioning$create`
cannot have a default value for `hive_null_fallback`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
