ZhangHuiGui commented on code in PR #41975:
URL: https://github.com/apache/arrow/pull/41975#discussion_r1637460847
##########
cpp/src/arrow/compute/exec.cc:
##########
@@ -966,12 +998,6 @@ class ScalarExecutor : public
KernelExecutorImpl<ScalarKernel> {
data_preallocated_.size() == static_cast<size_t>(output_num_buffers_
- 1) &&
!is_nested(out_type_id) && !is_dictionary(out_type_id));
- // TODO(wesm): why was this check ever here? Fixed width binary
Review Comment:
We can keep the DCHECK you suggested before (
https://github.com/apache/arrow/pull/41975/files#r1636669846 which you
suggest). In essence, they detect the same content, otherwise there will be two
duplicate DCHECKs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
