ZhangHuiGui commented on PR #41975: URL: https://github.com/apache/arrow/pull/41975#issuecomment-2166010762
> I will finish the review later. I need to check that code movement mor carefully. It would help to have a commit history with two commits: > > 1. refactoring the setup preallocation logic in-place > 2. extracting that refactored logic to a function > > Code movement + changes mixed together takes more time to review. It's my fault. Thanks so much for your review @felipecrv @mapleFU. I reorganized the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
